Skip to content

33581: Eliminated AspectMock where it was imported but never used #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2021
Merged

33581: Eliminated AspectMock where it was imported but never used #862

merged 1 commit into from
Aug 2, 2021

Conversation

@anzin
Copy link
Contributor

@anzin anzin commented Jul 26, 2021 •
edited
Loading

Description

I've eliminated AspectMock where it was imported but never used.

Fixed Issues (if relevant)

  1. Fixes [MFTF] Eliminate AspectMock where it was imported but never used magento2#33581

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 26, 2021
@bohdan-harniuk bohdan-harniuk self-requested a review July 26, 2021 12:20
bohdan-harniuk
bohdan-harniuk approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @anzin!
Thank you for your contribution!

Hello, @jilu1!
Please, proceed with the code review!
Here we have just code refactoring. Directly AspectMock wasn't used.

Thanks, Bohdan

@bohdan-harniuk bohdan-harniuk requested a review from jilu1 July 26, 2021 12:25
andrewbess
andrewbess approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @anzin
Thank you for your contribution.
Changes look good for me.

@anzin anzin mentioned this pull request Jul 27, 2021
Merged
5 tasks
@KevinBKozan KevinBKozan self-requested a review July 30, 2021 14:50
@KevinBKozan
Copy link
Contributor

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

@magento-engcom-team
Copy link

@KevinBKozan the pull request successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 98f5e99 into magento:develop Aug 2, 2021
@KevinBKozan KevinBKozan mentioned this pull request Aug 2, 2021
Closed
@andrewbess andrewbess deleted the improvement/mftf-33581-eliminate-aspect-mock-from-import branch August 2, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jilu1 jilu1 Awaiting requested review from jilu1

@KevinBKozan KevinBKozan Awaiting requested review from KevinBKozan

2 more reviewers

@andrewbess andrewbess andrewbess approved these changes

@bohdan-harniuk bohdan-harniuk bohdan-harniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andrewbess andrewbess

@bohdan-harniuk bohdan-harniuk

Labels

in progress Partner: Atwix partners-contribution Pull Request is created by Magento Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MFTF] Eliminate AspectMock where it was imported but never used

6 participants

@anzin @KevinBKozan @magento-engcom-team @andrewbess @bohdan-harniuk @magento-devops-reposync-svc